RFR: Consolidate oop iterators

[Roman Kennke]

Am Dienstag, den 07.02.2017, 00:11 +0100 schrieb Aleksey Shipilev:
> On 02/06/2017 10:15 PM, Roman Kennke wrote:
> > http://cr.openjdk.java.net/~rkennke/consolidate-closures/webrev.00/
> 
> Looks good.
> 
>  *) I think we can ditch ShenandoahMarkRefsSuperClosure now, and make
> all
> subclasses extend MetadataAwareOopClosure directly.

Not easily. We still need to pass through the heap and queue ptrs, and
the ShenandoahMarkRefsSuperClosure seems a good place to do that.

>  *) If we migrate the last remaining use of SCM::mark_and_push in
> ShenandoahSATBBufferClosure, we can then merge mark_in_push into
> mark_through_ref, right?

Right. Like this:

http://cr.openjdk.java.net/~rkennke/consolidate-closures/webrev.01/


To be honest, I am not sure I like it. mark_through_refs() becomes less
readable, and I am not sure if there's an advantage here?

Anyway, good to go?

Roman