RFR: Consolidate oop iterators

Aleksey Shipilev shade at redhat.com
Tue Feb 7 09:29:25 UTC 2017


On 02/07/2017 10:25 AM, Roman Kennke wrote:
>>  *) If we migrate the last remaining use of SCM::mark_and_push in
>> ShenandoahSATBBufferClosure, we can then merge mark_in_push into
>> mark_through_ref, right?
> 
> Right. Like this:
> 
> http://cr.openjdk.java.net/~rkennke/consolidate-closures/webrev.01/
> 
> To be honest, I am not sure I like it. mark_through_refs() becomes less
> readable, and I am not sure if there's an advantage here?
> 
> Anyway, good to go?

Yes, good to go.

I guess part of the mess is multiple oopDesc::is_safe blocks and asserts.

Thanks,
-Aleksey



More information about the shenandoah-dev mailing list