RFR(S): Implementation of aarch64 interpreter matrix barrier

Andrew Haley aph at redhat.com
Wed Jun 21 16:48:42 UTC 2017


On 21/06/17 14:51, Zhengyu Gu wrote:
> Thanks for the review, Andrew and Aleksey,
> 
> I updated patch according to your comments:
> 
> Webrev: 
> http://cr.openjdk.java.net/~zgu/shenandoah/aarch64_int_matrix_barrier/webrev.01/

Much better, but assert that offset is zero or use lea.

+  ShenandoahConnectionMatrix* matrix = ShenandoahHeap::heap()->connection_matrix();
+  address matrix_addr = matrix->matrix_addr();
+  unsigned long offset;
+  adrp(rscratch2, ExternalAddress(ShenandoahHeap::heap()->base()), offset);

Thanks.

-- 
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671


More information about the shenandoah-dev mailing list