RFR(S): Implementation of aarch64 interpreter matrix barrier

Zhengyu Gu zgu at redhat.com
Wed Jun 21 17:24:01 UTC 2017


Oops, I pushed.

Added assertion here:

Webrev: 
http://cr.openjdk.java.net/~zgu/shenandoah/assert_heap_alignment/webrev.00/

Thanks,

-Zhengyu


On 06/21/2017 12:48 PM, Andrew Haley wrote:
> On 21/06/17 14:51, Zhengyu Gu wrote:
>> Thanks for the review, Andrew and Aleksey,
>>
>> I updated patch according to your comments:
>>
>> Webrev:
>> http://cr.openjdk.java.net/~zgu/shenandoah/aarch64_int_matrix_barrier/webrev.01/
>
> Much better, but assert that offset is zero or use lea.
>
> +  ShenandoahConnectionMatrix* matrix = ShenandoahHeap::heap()->connection_matrix();
> +  address matrix_addr = matrix->matrix_addr();
> +  unsigned long offset;
> +  adrp(rscratch2, ExternalAddress(ShenandoahHeap::heap()->base()), offset);
>
> Thanks.
>


More information about the shenandoah-dev mailing list