RFR: Only report GC pause time to GC MXBean

Aleksey Shipilev shade at redhat.com
Thu Apr 12 15:16:00 UTC 2018


On 04/12/2018 04:56 PM, Zhengyu Gu wrote:
> Webrev: http://cr.openjdk.java.net/~zgu/shenandoah/gc-mxbean/webrev.00/index.html

*) No chance for a quick test?

*) Is there any reason why we inherit from TraceMemoryManagerStats, and not composing with it, like
we do with GCIdMark, SvcGCMarker, IsGCActiveMark?

*) "GCPauseType pauseType" -> "GCPauseType pause_type"

*) GCPauseType constants should not be camel-case too? Suggestion:

   typedef enum {
     pause_init,
     pause_intermediate,
     pause_final,
     pause_full,
   } GCPauseType;

Thanks,
-Aleksey


More information about the shenandoah-dev mailing list