RFR: Only report GC pause time to GC MXBean
Zhengyu Gu
zgu at redhat.com
Thu Apr 12 17:40:05 UTC 2018
On 04/12/2018 11:16 AM, Aleksey Shipilev wrote:
> On 04/12/2018 04:56 PM, Zhengyu Gu wrote:
>> Webrev: http://cr.openjdk.java.net/~zgu/shenandoah/gc-mxbean/webrev.00/index.html
>
> *) No chance for a quick test?
Forgot to mention:
Passed hotspot_gc_shenandoah (fastdebug + release)
Eyeball outputs of manual test with various GC heuristics options
>
> *) Is there any reason why we inherit from TraceMemoryManagerStats, and not composing with it, like
> we do with GCIdMark, SvcGCMarker, IsGCActiveMark?
A bit hesitated to embed StackObj. Did not realize GCIdMark, SvcGCMarker
and etc. are StackObjs too, so changed as you suggested.
>
> *) "GCPauseType pauseType" -> "GCPauseType pause_type"
>
> *) GCPauseType constants should not be camel-case too? Suggestion:
>
> typedef enum {
> pause_init,
> pause_intermediate,
> pause_final,
> pause_full,
> } GCPauseType;
Fixed.
Updated Webrev:
http://cr.openjdk.java.net/~zgu/shenandoah/gc-mxbean/webrev.01/index.html
Test:
Reran all above tests.
Thanks,
-Zhengyu
>
> Thanks,
> -Aleksey
>
More information about the shenandoah-dev
mailing list