RFR: Trivial enhancement to avoid costly deletion array element

Zhengyu Gu zgu at redhat.com
Fri Aug 17 12:46:43 UTC 2018



On 08/17/2018 08:19 AM, Zhengyu Gu wrote:
> On 08/17/2018 03:07 AM, Aleksey Shipilev wrote:
>> On 08/16/2018 10:36 PM, Zhengyu Gu wrote:
>>> Trivial enhancement to avoid deletion array element, which may need 
>>> costly shifting tailing elements.
>>> Webrev: http://cr.openjdk.java.net/~zgu/shenandoah/replace_nm/webrev.00/
>>
>> Looks good!
>>
>> Have you seen this code as hot, or that was a hunch? It it fine either 
>> way.
> 
> No, it is not hot. I stumbled over while chasing a weird assertion failure.
> 
> Have you seen this? 
> https://paste.fedoraproject.org/paste/LyRkIj2w77dxFdWOv49yqA
> 
> or just my super *hot* computer tried to throw me something interesting :-(

Okay, reproduced again, I guess it is not a hoax.

-Zhengyu

> 
> -Zhengyu
> 
>>
>> Thanks,
>> -Aleksey
>>


More information about the shenandoah-dev mailing list