RFR: Some Shenandoah related additions to SA

Roman Kennke rkennke at redhat.com
Mon Dec 3 11:22:18 UTC 2018


>> following up on review by Jini, here are some additions to SA that are
>> related to Shenandoah:
>>
>> http://cr.openjdk.java.net/~rkennke/shenandoah-sa/webrev.00/
> 
> *) Note you still have src/hotspot/share/opto/classes.cpp in queue.
> 
> *) HSDB.java: probably move the block between EpsilonHeap and ZCollectedHeap to pretend it is sorted
> alphabetically?
> 
> *) GCCause.java: this should be "Concurrent GC", I think:
> 
>   72   _shenandoah_concurrent_gc ("Current GC"),
> 
> *) GGCause.java: Message Should Be Capitalized, I Think, For Consistency:
> 
>   71   _shenandoah_allocation_failure_evac ("Allocation Failure during evacuation"),
> 

This better?

http://cr.openjdk.java.net/~rkennke/shenandoah-sa/webrev.01/

Roman



More information about the shenandoah-dev mailing list