RFR: Some Shenandoah related additions to SA

Aleksey Shipilev shade at redhat.com
Mon Dec 3 11:23:21 UTC 2018


On 12/3/18 12:22 PM, Roman Kennke wrote:
>>> following up on review by Jini, here are some additions to SA that are
>>> related to Shenandoah:
>>>
>>> http://cr.openjdk.java.net/~rkennke/shenandoah-sa/webrev.00/
>>
>> *) Note you still have src/hotspot/share/opto/classes.cpp in queue.
>>
>> *) HSDB.java: probably move the block between EpsilonHeap and ZCollectedHeap to pretend it is sorted
>> alphabetically?
>>
>> *) GCCause.java: this should be "Concurrent GC", I think:
>>
>>   72   _shenandoah_concurrent_gc ("Current GC"),
>>
>> *) GGCause.java: Message Should Be Capitalized, I Think, For Consistency:
>>
>>   71   _shenandoah_allocation_failure_evac ("Allocation Failure during evacuation"),
>>
> 
> This better?
> 
> http://cr.openjdk.java.net/~rkennke/shenandoah-sa/webrev.01/

Yup!

-Aleksey



More information about the shenandoah-dev mailing list