MacOS build warnings (trivial)

Aleksey Shipilev shade at redhat.com
Mon Mar 12 17:23:13 UTC 2018


Thanks!

On 03/09/2018 11:37 AM, Lennart Börjeson wrote:
> /Users/lennartb/RaT/openJDK/shenandoah/src/hotspot/share/opto/escape.cpp:518:84: warning: '&&' within '||' [-Wlogical-op-parentheses]
>           (opcode == Op_StoreP || opcode == Op_StoreN || opcode == Op_StoreNKlass) &&
>           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
> /Users/lennartb/RaT/openJDK/shenandoah/src/hotspot/share/opto/escape.cpp:518:84: note: place parentheses around the '&&' expression to silence this warning
>           (opcode == Op_StoreP || opcode == Op_StoreN || opcode == Op_StoreNKlass) &&
>                                                                                    ^
> /Users/lennartb/RaT/openJDK/shenandoah/src/hotspot/share/opto/escape.cpp:737:84: warning: '&&' within '||' [-Wlogical-op-parentheses]
>           (opcode == Op_StoreP || opcode == Op_StoreN || opcode == Op_StoreNKlass) &&
>           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
> /Users/lennartb/RaT/openJDK/shenandoah/src/hotspot/share/opto/escape.cpp:737:84: note: place parentheses around the '&&' expression to silence this warning
>           (opcode == Op_StoreP || opcode == Op_StoreN || opcode == Op_StoreNKlass) &&

Should be fixed by:
  http://hg.openjdk.java.net/shenandoah/jdk/rev/1c743cca5468

> /Users/lennartb/RaT/openJDK/shenandoah/src/hotspot/share/opto/memnode.cpp:1136:48: warning: '&&' within '||' [-Wlogical-op-parentheses]
>             value->in(0)->in(1)->in(0) != NULL &&
>             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
> /Users/lennartb/RaT/openJDK/shenandoah/src/hotspot/share/opto/memnode.cpp:1136:48: note: place parentheses around the '&&' expression to silence this warning
>             value->in(0)->in(1)->in(0) != NULL &&
>                                                ^
> /Users/lennartb/RaT/openJDK/shenandoah/src/hotspot/share/opto/memnode.cpp:1271:66: warning: '&&' within '||' [-Wlogical-op-parentheses]
>              (count == 2) && elements[1]->Opcode() == Op_LShiftX &&
>              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
> /Users/lennartb/RaT/openJDK/shenandoah/src/hotspot/share/opto/memnode.cpp:1271:66: note: place parentheses around the '&&' expression to silence this warning
>              (count == 2) && elements[1]->Opcode() == Op_LShiftX &&

Should be fixed by:
  http://hg.openjdk.java.net/shenandoah/jdk/rev/5789a22b66bd

Please try building again?

Thanks,
-Aleksey



More information about the shenandoah-dev mailing list