MacOS build warnings (trivial)

Lennart Börjeson lennart.borjeson at cinnober.com
Tue Mar 13 08:59:37 UTC 2018


Built OK!
Tested with "hotspot_gc_shenandoah" OK!

/Lennart

> 12 mars 2018 kl. 18:23 skrev Aleksey Shipilev <shade at redhat.com>:
> 
> Thanks!
> 
> On 03/09/2018 11:37 AM, Lennart Börjeson wrote:
>> /Users/lennartb/RaT/openJDK/shenandoah/src/hotspot/share/opto/escape.cpp:518:84: warning: '&&' within '||' [-Wlogical-op-parentheses]
>>          (opcode == Op_StoreP || opcode == Op_StoreN || opcode == Op_StoreNKlass) &&
>>          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
>> /Users/lennartb/RaT/openJDK/shenandoah/src/hotspot/share/opto/escape.cpp:518:84: note: place parentheses around the '&&' expression to silence this warning
>>          (opcode == Op_StoreP || opcode == Op_StoreN || opcode == Op_StoreNKlass) &&
>>                                                                                   ^
>> /Users/lennartb/RaT/openJDK/shenandoah/src/hotspot/share/opto/escape.cpp:737:84: warning: '&&' within '||' [-Wlogical-op-parentheses]
>>          (opcode == Op_StoreP || opcode == Op_StoreN || opcode == Op_StoreNKlass) &&
>>          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
>> /Users/lennartb/RaT/openJDK/shenandoah/src/hotspot/share/opto/escape.cpp:737:84: note: place parentheses around the '&&' expression to silence this warning
>>          (opcode == Op_StoreP || opcode == Op_StoreN || opcode == Op_StoreNKlass) &&
> 
> Should be fixed by:
>  http://hg.openjdk.java.net/shenandoah/jdk/rev/1c743cca5468
> 
>> /Users/lennartb/RaT/openJDK/shenandoah/src/hotspot/share/opto/memnode.cpp:1136:48: warning: '&&' within '||' [-Wlogical-op-parentheses]
>>            value->in(0)->in(1)->in(0) != NULL &&
>>            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
>> /Users/lennartb/RaT/openJDK/shenandoah/src/hotspot/share/opto/memnode.cpp:1136:48: note: place parentheses around the '&&' expression to silence this warning
>>            value->in(0)->in(1)->in(0) != NULL &&
>>                                               ^
>> /Users/lennartb/RaT/openJDK/shenandoah/src/hotspot/share/opto/memnode.cpp:1271:66: warning: '&&' within '||' [-Wlogical-op-parentheses]
>>             (count == 2) && elements[1]->Opcode() == Op_LShiftX &&
>>             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
>> /Users/lennartb/RaT/openJDK/shenandoah/src/hotspot/share/opto/memnode.cpp:1271:66: note: place parentheses around the '&&' expression to silence this warning
>>             (count == 2) && elements[1]->Opcode() == Op_LShiftX &&
> 
> Should be fixed by:
>  http://hg.openjdk.java.net/shenandoah/jdk/rev/5789a22b66bd
> 
> Please try building again?
> 
> Thanks,
> -Aleksey
> 



More information about the shenandoah-dev mailing list