RFR: Break heuristics out from ShCollectorPolicy into their own source files

Aleksey Shipilev shade at redhat.com
Tue May 8 09:25:38 UTC 2018


On 05/07/2018 10:22 PM, Roman Kennke wrote:
> Another one that I wanted to do since a long time, and which now is
> needed in preparation for the interleaving of minor/major GC change.
> 
> - Break out all the heuristics into their own source files
> - split declarations from definitions into .hpp/.cpp files
> 
> 
> This was a pretty mechanic refactoring, no logic changes (hopefully).
> 
> http://cr.openjdk.java.net/~rkennke/shheuristics/webrev.00/

*) Nothing prevents us from putting these into subfolder, right? That would group all of them in
filesystem and in the includes. E.g.: gc/share/shenandoah/heuristics/

*) Also, we might just merge:
  shenandoahLRUPartialHeuristics.*
  shenandoahPartialConnectedHeuristics.*
  shenandoahGenerationalPartialHeuristics.*

Into common:
  shenandoahPartialHeuristics.*

Or, at very least make their names consistent: shenandoahPartial{$Type}Heuristics, so they naturally
cluster together.

*) Also, shenandoahStaticHeuristics has only the header, with definitions inlined, but others seem
to have their own .cpp.

Thanks,
-Aleksey



More information about the shenandoah-dev mailing list