RFR: Break heuristics out from ShCollectorPolicy into their own source files
Roman Kennke
rkennke at redhat.com
Tue May 8 17:00:01 UTC 2018
Am 08.05.2018 um 11:25 schrieb Aleksey Shipilev:
> On 05/07/2018 10:22 PM, Roman Kennke wrote:
>> Another one that I wanted to do since a long time, and which now is
>> needed in preparation for the interleaving of minor/major GC change.
>>
>> - Break out all the heuristics into their own source files
>> - split declarations from definitions into .hpp/.cpp files
>>
>>
>> This was a pretty mechanic refactoring, no logic changes (hopefully).
>>
>> http://cr.openjdk.java.net/~rkennke/shheuristics/webrev.00/
>
> *) Nothing prevents us from putting these into subfolder, right? That would group all of them in
> filesystem and in the includes. E.g.: gc/share/shenandoah/heuristics/
Good idea. Done it.
> *) Also, we might just merge:
> shenandoahLRUPartialHeuristics.*
> shenandoahPartialConnectedHeuristics.*
> shenandoahGenerationalPartialHeuristics.*
>
> Into common:
> shenandoahPartialHeuristics.*
>
> Or, at very least make their names consistent: shenandoahPartial{$Type}Heuristics, so they naturally
> cluster together.
I renamed them to be consistent. The heuristics are not so small that
I'd group them together.
> *) Also, shenandoahStaticHeuristics has only the header, with definitions inlined, but others seem
> to have their own .cpp.
An oversight. I fixed it.
http://cr.openjdk.java.net/~rkennke/shheuristics/webrev.01/
Ok?
Roman
More information about the shenandoah-dev
mailing list