RFR: Move heuristics from ShCollectorPolicy to ShHeap

[Roman Kennke]

Am 16.05.2018 um 16:46 schrieb Aleksey Shipilev:
> On 05/16/2018 04:20 PM, Roman Kennke wrote:
>> All the should* and can* methods are now called directly without hopping
>> through ShCollectorPolicy. However, all the record* methods remain in
>> the policy for now. I am not sure yet what to do with them: we may want
>> to call them per-context (e.g. a context recording only its own GC
>> activity) or globally (e.g. for stats) or both. I need to think this
>> through when I do the multi-context stuff.
>>
>> http://cr.openjdk.java.net/~rkennke/heuristics-refactoring/webrev.00/
> 
> I like the way it goes, but my problem with this move is that we would need to shuffle this code
> twice: 1) ShCollectorPolicy -> ShHeap; 2) ShHeap -> Sh*Context. Which is fine for sh/jdk, but really
> gives headaches during backports. So, I would rather prefer to make a single move to Sh*Context,
> when time comes. Is that doable?

Sure. But this will pull in more moving-around of other stuff. I was
thinking to take smaller, more manageable steps instead :-) Also: not
sure we want the multi-context stuff in backports?

Roman