RFR: Move heuristics from ShCollectorPolicy to ShHeap
Aleksey Shipilev
shade at redhat.com
Wed May 16 14:46:16 UTC 2018
On 05/16/2018 04:20 PM, Roman Kennke wrote:
> All the should* and can* methods are now called directly without hopping
> through ShCollectorPolicy. However, all the record* methods remain in
> the policy for now. I am not sure yet what to do with them: we may want
> to call them per-context (e.g. a context recording only its own GC
> activity) or globally (e.g. for stats) or both. I need to think this
> through when I do the multi-context stuff.
>
> http://cr.openjdk.java.net/~rkennke/heuristics-refactoring/webrev.00/
I like the way it goes, but my problem with this move is that we would need to shuffle this code
twice: 1) ShCollectorPolicy -> ShHeap; 2) ShHeap -> Sh*Context. Which is fine for sh/jdk, but really
gives headaches during backports. So, I would rather prefer to make a single move to Sh*Context,
when time comes. Is that doable?
-Aleksey
More information about the shenandoah-dev
mailing list