RFR: Move heuristics from ShCollectorPolicy to ShHeap

Aleksey Shipilev shade at redhat.com
Thu May 17 12:19:15 UTC 2018


On 05/17/2018 02:12 PM, Roman Kennke wrote:
> Am 16.05.2018 um 18:26 schrieb Aleksey Shipilev:
>> On 05/16/2018 05:19 PM, Roman Kennke wrote:
>>> I simply spliced all the calls to policy that also called to heuristics
>>> into two calls: policy+heuristics or changed to heuristics call for
>>> cases where policy did not do anything.
>>>
>>> Remaining record* stuff in policy should probably be moved into a
>>> separate ShenandoahStats class or such.
>>>
>>> Differential:
>>> http://cr.openjdk.java.net/~rkennke/heuristics-refactoring/webrev.01.diff/
>>> Full:
>>> http://cr.openjdk.java.net/~rkennke/heuristics-refactoring/webrev.01/
>>
>> Looks OK. Have somebody else eyeball this, because I cannot trust my eyes anymore today. Or wait for
>> tomorrow.
> 
> Did you find some time to look at it? I will disappear soonish for 1.5
> weeks... ;-)

Looks good, push it.

-Aleksey



More information about the shenandoah-dev mailing list