RFR: Shenandoah filter for gc/TestFullGCCount.java test

Aleksey Shipilev shade at redhat.com
Wed Nov 14 19:50:34 UTC 2018


On 11/14/2018 08:39 PM, Zhengyu Gu wrote:
> Shenandoah, by default, sets ExplicitGCInvokesConcurrent = true, which means it runs concurrent GC
> for System.gc().
> 
> We need to filter out the test, unless ExplicitGCInvokesConcurrent is explicitly set to false.
> 
> Webrev: http://cr.openjdk.java.net/~zgu/shenandoah/filter_conc_system_gc/webrev.00/

I think this is one of those rare cases when multiple @requires are better, e.g:

 * @requires !(vm.gc.ConcMarkSweep & vm.opt.ExplicitGCInvokesConcurrent == true)
 * @requires !(vm.gc.Shenandoah    & vm.opt.ExplicitGCInvokesConcurrent == false)

Does this work?

-Aleksey



More information about the shenandoah-dev mailing list