RFR: Shenandoah filter for gc/TestFullGCCount.java test

Zhengyu Gu zgu at redhat.com
Wed Nov 14 19:53:52 UTC 2018



On 11/14/18 2:50 PM, Aleksey Shipilev wrote:
> On 11/14/2018 08:39 PM, Zhengyu Gu wrote:
>> Shenandoah, by default, sets ExplicitGCInvokesConcurrent = true, which means it runs concurrent GC
>> for System.gc().
>>
>> We need to filter out the test, unless ExplicitGCInvokesConcurrent is explicitly set to false.
>>
>> Webrev: http://cr.openjdk.java.net/~zgu/shenandoah/filter_conc_system_gc/webrev.00/
> 
> I think this is one of those rare cases when multiple @requires are better, e.g:
> 
>   * @requires !(vm.gc.ConcMarkSweep & vm.opt.ExplicitGCInvokesConcurrent == true)
>   * @requires !(vm.gc.Shenandoah    & vm.opt.ExplicitGCInvokesConcurrent == false)
> 
> Does this work?

Yep, it works.

Will push this one once Roman ack.

Thanks,

-Zhengyu

> 
> -Aleksey
> 


More information about the shenandoah-dev mailing list