RFR: In update-refs, update all code-roots when in degen-gc

Roman Kennke rkennke at redhat.com
Wed Sep 12 11:23:49 UTC 2018


Am 12.09.2018 um 13:06 schrieb Aleksey Shipilev:
> On 09/12/2018 01:02 PM, Roman Kennke wrote:
>> http://cr.openjdk.java.net/~rkennke/fix-assert-fwd/webrev.00/
> 
> You also need to have the per-root block following the degen_gc_update_roots declaration. See e.g.:
> 
>  207     // Per-thread timer block, should have "roots" counters in consistent order
>  208     final_traversal_update_roots,
>  209     final_traversal_update_thread_roots,
>   ....
> 
> Otherwise ShenandoahPhaseTimings::record_workers_end would screw up adjacent counters.

Ok:
http://cr.openjdk.java.net/~rkennke/fix-assert-fwd/webrev.01/

Good?

Roman


More information about the shenandoah-dev mailing list