RFR: In update-refs, update all code-roots when in degen-gc

[Aleksey Shipilev]

On 09/12/2018 01:23 PM, Roman Kennke wrote:
> Am 12.09.2018 um 13:06 schrieb Aleksey Shipilev:
>> On 09/12/2018 01:02 PM, Roman Kennke wrote:
>>> http://cr.openjdk.java.net/~rkennke/fix-assert-fwd/webrev.00/
>>
>> You also need to have the per-root block following the degen_gc_update_roots declaration. See e.g.:
>>
>>  207     // Per-thread timer block, should have "roots" counters in consistent order
>>  208     final_traversal_update_roots,
>>  209     final_traversal_update_thread_roots,
>>   ....
>>
>> Otherwise ShenandoahPhaseTimings::record_workers_end would screw up adjacent counters.
> 
> Ok:
> http://cr.openjdk.java.net/~rkennke/fix-assert-fwd/webrev.01/

Not sure why these are broken out with new-lines:

 224   _phase_names[degen_gc_update_string_dedup_table_roots]
 225                                                            = "    DU: Dedup Table Roots";
 226   _phase_names[degen_gc_update_string_dedup_queue_roots]
 227                                                            = "    DU: Dedup Queue Roots";

...otherwise looks fine! You might want to fix that before pushing.

Thanks,
-Aleksey