RFR: JDK-8222926: Unify cpu related part of shenandoahBarrierSetC1 and fix build when compiler1 is disabled

[Ao Qi]

Hi,

The patch [1] dose not apply cleanly again because of JDK-8223449. And
src/hotspot/share/jvmci/vmStructs_jvmci.cpp needs to be updated. Here
is a new version:

http://cr.openjdk.java.net/~aoqi/8222926/webrev.02/

Could I please get reviews? (cc'ed shenandoah-dev)

Thanks,
Ao Qi

[1] http://cr.openjdk.java.net/~aoqi/8222926/webrev.01/



On Fri, Apr 26, 2019 at 3:59 PM Ao Qi <aoqi at loongson.cn> wrote:
>
> Hi,
>
> The patch [1] dose not apply cleanly any more, because of the same
> copyright update in JDK-8222811 [2]. I updated a new version to
> exclude this copyright modification:
>
> http://cr.openjdk.java.net/~aoqi/8222926/webrev.01/
>
> Could I please get reviews for this?
>
> Thanks,
> Ao Qi
>
> [1] http://cr.openjdk.java.net/~aoqi/8222926/webrev.00/
> [2] http://hg.openjdk.java.net/jdk/jdk/diff/1126f0607c70/src/hotspot/share/code/codeBlob.cpp#l1.6
>
>
> On Wed, Apr 24, 2019 at 9:56 PM Ao Qi <aoqi at loongson.cn> wrote:
> >
> > Hi,
> >
> > When I configure using --with-jvm-features=-compiler1, I found build
> > is broken. The main cause is that some shenandoah related part did not
> > consider the situation when compiler1 is disabled. I also found that
> > src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetC1_aarch64.cpp
> > and src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetC1_x86.cpp
> > were basically the same, with only small differences. I unified these
> > two files and moved the result to a c1 related file. I also fixed one
> > "#undef" only when COMPILER1 is true in
> > shenandoahBarrierSetAssembler_x86/aarch64.cpp and one missed include
> > in codeBlob.cpp.
> >
> > Bug:
> > https://bugs.openjdk.java.net/browse/JDK-8222926/
> >
> > Webrev:
> > http://cr.openjdk.java.net/~aoqi/8222926/webrev.00/
> >
> > Tested:
> >   - build: linux-x86_64-{server, zero, minimal}-{release, fastdebug},
> > linux-aarch64-server-release
> >   - jtreg: linux-x86_64-server-release tier1,
> > linux-aarch64-server-release tier1_gc_shenandoah
> >
> > Thanks,
> > Ao Qi