[sh/jdk8u] RFR Shenandoah: missing SystemDictionary roots in ShenandoahHeapIterationRootScanner

Aleksey Shipilev shade at redhat.com
Wed Jun 10 14:12:39 UTC 2020


On 6/10/20 4:09 PM, Zhengyu Gu wrote:
> Please review this patch that adds SystemDictionaryRoots to 
> ShenandoahHeapIterationRootScanner. It appears to be the cause of recent 
> TCK 8 test failures.
> 
> Webrev: 
> http://cr.openjdk.java.net/~zgu/shenandoah/heap_itr_scanner/webrev.00/index.html

*) Indenting nit at L190 here:

 189   ShenandoahSerialRoots                                    _serial_roots;
 190   ShenandoahSystemDictionaryRoots _dict_roots;
 191   ShenandoahThreadRoots                                    _thread_roots;

This is 8u specific, right?

If so, looks good!

-- 
Thanks,
-Aleksey



More information about the shenandoah-dev mailing list