[sh/jdk8u] RFR Shenandoah: missing SystemDictionary roots in ShenandoahHeapIterationRootScanner

Zhengyu Gu zgu at redhat.com
Wed Jun 10 14:46:07 UTC 2020



On 6/10/20 10:12 AM, Aleksey Shipilev wrote:
> On 6/10/20 4:09 PM, Zhengyu Gu wrote:
>> Please review this patch that adds SystemDictionaryRoots to
>> ShenandoahHeapIterationRootScanner. It appears to be the cause of recent
>> TCK 8 test failures.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~zgu/shenandoah/heap_itr_scanner/webrev.00/index.html
> 
> *) Indenting nit at L190 here:
> 
>   189   ShenandoahSerialRoots                                    _serial_roots;
>   190   ShenandoahSystemDictionaryRoots _dict_roots;
>   191   ShenandoahThreadRoots                                    _thread_roots

Fixed.

> 
> This is 8u specific, right?

Yes. It is 8u specific.

Thanks for the quick review. Pushed.

-Zhengyu

> 
> If so, looks good!
> 



More information about the shenandoah-dev mailing list