[sh/jdk8u] RFR Shenandoah: add JFR roots to root processor after JFR integration

[Zhengyu Gu]

Hi Aleksey,

On 6/10/20 12:35 PM, Aleksey Shipilev wrote:
> On 6/10/20 5:39 PM, Zhengyu Gu wrote:
>> Webrev:
>> http://cr.openjdk.java.net/~zgu/shenandoah/jfr_root_processing/webrev.00/index.html
> 
> Looks fine, nits below:
> 
> *) Any reason not to use JFR_ONLY here?
> 
>   141 ShenandoahWeakRoots::ShenandoahWeakRoots(ShenandoahPhaseTimings::Phase phase) :
>   142 #if INCLUDE_JFR
>   143   _jfr_weak_roots(phase, ShenandoahPhaseTimings::JFRWeakRoots, &LeakProfiler::oops_do),
>   144 #endif // INCLUDE_JFR
>   145   _jni_weak_roots(phase, ShenandoahPhaseTimings::JNIWeakRoots, &JNIHandles::weak_oops_do) {
>   146 }

Compiler does not like, it thinks JFR_ONLY is a member variable.

> 
> 
> *) I was under impression that when you use #if for some global macro, you need to #include
> "utilities/macros.hpp".

PCH and non-PCH builds are happy without it, but add the header anyway.

Pushed.

Thanks,

-Zhengyu

> 
> So...
> 
>> Test:
>>     hotspot_gc_shenandoah (+/- JFR)
> 
> ...try with -PCH?
> 
>