[sh/jdk8u] RFR Shenandoah: add JFR roots to root processor after JFR integration
Aleksey Shipilev
shade at redhat.com
Wed Jun 10 17:59:51 UTC 2020
On 6/10/20 7:55 PM, Zhengyu Gu wrote:
> On 6/10/20 12:35 PM, Aleksey Shipilev wrote:
>> On 6/10/20 5:39 PM, Zhengyu Gu wrote:
>>> Webrev:
>>> http://cr.openjdk.java.net/~zgu/shenandoah/jfr_root_processing/webrev.00/index.html
>>
>> Looks fine, nits below:
>>
>> *) Any reason not to use JFR_ONLY here?
>>
>> 141 ShenandoahWeakRoots::ShenandoahWeakRoots(ShenandoahPhaseTimings::Phase phase) :
>> 142 #if INCLUDE_JFR
>> 143 _jfr_weak_roots(phase, ShenandoahPhaseTimings::JFRWeakRoots, &LeakProfiler::oops_do),
>> 144 #endif // INCLUDE_JFR
>> 145 _jni_weak_roots(phase, ShenandoahPhaseTimings::JNIWeakRoots, &JNIHandles::weak_oops_do) {
>> 146 }
>
> Compiler does not like, it thinks JFR_ONLY is a member variable.
Whoa. But that is a smoking gun that macro is undefined (due to missing #include), right?
--
Thanks,
-Aleksey
More information about the shenandoah-dev
mailing list