RFR: JDK-8240315: Shenandoah: Rename ShLBN::get_barrier_strength()

[Aleksey Shipilev]

On 3/5/20 5:42 PM, Roman Kennke wrote:
> I would like to rename
> ShenandoahLoadReferenceBarrierNode::get_barrier_strength() to
> is_lrb_useful(). See:
> 
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8240315
> Webrev:
> http://cr.openjdk.java.net/~rkennke/JDK-8240315/webrev.00/

*) "lrb" seems redundant, better be "is_useful"?

*) Given how all uses invert the returned value, maybe we should revert the meaning to be
"is_redundant"?

*) This comment is outdated:

3198   // Look for strongest strength: go over nodes looking for STRONG ones.
3199   // Stop once we encountered STRONG. Otherwise, walk until we ran out of nodes,
3200   // and then the overall strength is NONE.

-- 
Thanks,
-Aleksey