RFR: JDK-8240315: Shenandoah: Rename ShLBN::get_barrier_strength()

[Roman Kennke]

Hi Aleksey,

>> I would like to rename
>> ShenandoahLoadReferenceBarrierNode::get_barrier_strength() to
>> is_lrb_useful(). See:
>>
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8240315
>> Webrev:
>> http://cr.openjdk.java.net/~rkennke/JDK-8240315/webrev.00/
> 
> *) "lrb" seems redundant, better be "is_useful"?

Ok.

> *) Given how all uses invert the returned value, maybe we should revert the meaning to be
> "is_redundant"?

Right. Done.

> *) This comment is outdated:
> 
> 3198   // Look for strongest strength: go over nodes looking for STRONG ones.
> 3199   // Stop once we encountered STRONG. Otherwise, walk until we ran out of nodes,
> 3200   // and then the overall strength is NONE.

Right. I've updated it.


http://cr.openjdk.java.net/~rkennke/JDK-8240315/webrev.01/

Ok now?

Roman