RFR: Generation affiliation transitions for heap regions.
Bernd Mathiske
bmathiske at openjdk.java.net
Tue Nov 17 13:25:16 UTC 2020
On Tue, 17 Nov 2020 11:08:18 GMT, Roman Kennke <rkennke at openjdk.org> wrote:
>> Preparatory renaming generation->affiliation since we will want to have a class called ShenandoahGeneration that is not an enum. The next PR will build on this. It will be a big refactoring that pulls code out of the ShenandoahHeap class and puts it into generation-specific classes that are subclasses of ShenandoahGeneration.
>>
>> The Affiliation declaration still sits in AllocRequest and not in ShenandoahHeapRegion or ShenandoahGeneration for the same reason as before: it is hard to get anything to compile in other combinations of what goes where. I tried.
>>
>> The card table update code in the set_affiliation() will be revised and augmented later, but seems OK as a first step.
>
> src/hotspot/share/gc/shenandoah/shenandoahCardTable.cpp line 26:
>
>> 24:
>> 25: #include "precompiled.hpp"
>> 26: #include "gc/shared/memset_with_concurrent_readers.hpp"
>
> What's this?
Not needed. Removing it.
(This is a remnant from a former version of mine where more functionality was hosted in this class. Tsktsk.)
-------------
PR: https://git.openjdk.java.net/shenandoah/pull/7
More information about the shenandoah-dev
mailing list