RFR: Generation affiliation transitions for heap regions.
Bernd Mathiske
bmathiske at openjdk.java.net
Tue Nov 17 13:28:24 UTC 2020
On Tue, 17 Nov 2020 11:09:07 GMT, Roman Kennke <rkennke at openjdk.org> wrote:
>> Preparatory renaming generation->affiliation since we will want to have a class called ShenandoahGeneration that is not an enum. The next PR will build on this. It will be a big refactoring that pulls code out of the ShenandoahHeap class and puts it into generation-specific classes that are subclasses of ShenandoahGeneration.
>>
>> The Affiliation declaration still sits in AllocRequest and not in ShenandoahHeapRegion or ShenandoahGeneration for the same reason as before: it is hard to get anything to compile in other combinations of what goes where. I tried.
>>
>> The card table update code in the set_affiliation() will be revised and augmented later, but seems OK as a first step.
>
> src/hotspot/share/gc/shenandoah/shenandoahCardTable.hpp line 41:
>
>> 39: virtual void initialize();
>> 40:
>> 41: virtual inline bool is_in_young(oop obj) const {
>
> Why do we need virtual here? Is it overridden anywhere?
Removing "virtual".
-------------
PR: https://git.openjdk.java.net/shenandoah/pull/7
More information about the shenandoah-dev
mailing list