RFR: 8243208: Clean up JVMFlag implementation [v3]

[David Holmes]

On Wed, 9 Sep 2020 06:28:59 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> The initial commit [d85cbd6](https://github.com/openjdk/jdk/commit/d85cbd638f5b87c80eee9a92d10e1ac19d9bb2f8) is the
>> same patch as
>> [8243208-cleanup-jvmflag-impl.v02](https://cr.openjdk.java.net/~iklam/jdk16/8243208-cleanup-jvmflag-impl.v02/)
>> published in
>> [hotspot-dev at openjdk.java.net](https://mail.openjdk.java.net/pipermail/hotspot-dev/2020-September/042863.html).  The
>> rest of the review will continue on GitHub. I will add new commits to respond to comments to the above e-mail.
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed JVMFlag::is_writeable()

Updates seem okay. One query below.

src/hotspot/share/runtime/flags/jvmFlag.cpp line 266:

> 264:
> 265: bool JVMFlag::is_writeable() const {
> 266:   return is_manageable();

Unclear why is_writeable() reduces to is_manageable(). Aren't all product flags writeable? And aren't all develop flags
writeable in non-product builds?

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/82