RFR: 8243208: Clean up JVMFlag implementation [v3]

Coleen Phillimore coleenp at openjdk.java.net
Wed Sep 9 14:20:03 UTC 2020


On Wed, 9 Sep 2020 13:11:12 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed JVMFlag::is_writeable()
>
> src/hotspot/share/runtime/flags/jvmFlag.cpp line 266:
> 
>> 264:
>> 265: bool JVMFlag::is_writeable() const {
>> 266:   return is_manageable();
> 
> Unclear why is_writeable() reduces to is_manageable(). Aren't all product flags writeable? And aren't all develop flags
> writeable in non-product builds?

All flags shouldn't be also writeable.  Interpreter code generation depends on static value of some flags, for instance.

-------------

PR: https://git.openjdk.java.net/jdk/pull/82


More information about the shenandoah-dev mailing list