RFR: 8253434: Shenandoah: Cleanup ShenandoahRootScanner [v2]

Roman Kennke rkennke at openjdk.java.net
Tue Sep 22 10:09:49 UTC 2020


On Mon, 21 Sep 2020 20:08:28 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

>> After moving CLDG mark to concurrent phase, ShenandoahRootScanner::strong_roots_do() and
>> ShenandoahRootScanner::roots_do() are practical the same, let's trim one.
>> Test:
>>   hotspot_gc_shenandoah
>
> Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   No need to mark on-stack CLD

src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp line 196:

> 194: }
> 195:
> 196: void ShenandoahRootScanner::roots_do(uint worker_id, OopClosure* oops, CLDClosure* clds, CodeBlobClosure* code,
> ThreadClosure *tc) {

You're still passing a (NULL) CLDClosure here, but it's not used. Or am I missing something? The method argument could
be eliminated altogether.

-------------

PR: https://git.openjdk.java.net/jdk/pull/286


More information about the shenandoah-dev mailing list