RFR: 8253434: Shenandoah: Cleanup ShenandoahRootScanner [v2]

Zhengyu Gu zgu at openjdk.java.net
Tue Sep 22 12:59:49 UTC 2020


On Tue, 22 Sep 2020 10:07:25 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   No need to mark on-stack CLD
>
> src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp line 196:
> 
>> 194: }
>> 195:
>> 196: void ShenandoahRootScanner::roots_do(uint worker_id, OopClosure* oops, CLDClosure* clds, CodeBlobClosure* code,
>> ThreadClosure *tc) {
> 
> You're still passing a (NULL) CLDClosure here, but it's not used. Or am I missing something? The method argument could
> be eliminated altogether.

It is unused, removed.

Thanks

-------------

PR: https://git.openjdk.java.net/jdk/pull/286


More information about the shenandoah-dev mailing list