RFR: Mixed evacuation [v7]

[Kelvin Nilsen]

On Thu, 22 Apr 2021 15:12:58 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Cosmetic improvements requested by review
>>   
>>   Following these changes, we ran jtreg TIER1 and hotspot_gc_shenandoah tests with no regressions.
>>   Also ran a stress Extremem workload.
>
> src/hotspot/share/gc/shenandoah/mode/shenandoahMode.cpp line 58:
> 
>> 56: ShenandoahOldHeuristics* ShenandoahMode::initialize_old_heuristics(ShenandoahGeneration* generation) const {
>> 57: 
>> 58:   if (ShenandoahGCHeuristics != NULL) {
> 
> Should be assert or guarantee ?

Thanks.  Replaced with assert.  Will see in next commit.

> src/hotspot/share/gc/shenandoah/mode/shenandoahPassiveMode.cpp line 65:
> 
>> 63: 
>> 64: ShenandoahOldHeuristics* ShenandoahPassiveMode::initialize_old_heuristics(ShenandoahGeneration* generation) const {
>> 65:   if (ShenandoahGCHeuristics != NULL) {
> 
> Looks like you can convert this if stmt to assert or guarantee?

Thanks for careful second review of the code.  This is changed to assert in next commit.

> src/hotspot/share/gc/shenandoah/shenandoahGeneration.hpp line 130:
> 
>> 128:   virtual bool is_concurrent_mark_in_progress() = 0;
>> 129: 
>> 130:  private:
> 
> Style nit: no leading space. The same as "protected" above (pre-exist)

Thanks.  I've fixed private.  Also fixed protected above.  They both had spaces.  Will see these changes in next commit.

> src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp line 496:
> 
>> 494:   CollectedHeap(),
>> 495:   _gc_generation(NULL),
>> 496:   _old_heuristics(NULL),
> 
> Minor style nit: jdk17 started to use nullptr to replace NULL

Thanks.  Fixed in next commit.

-------------

PR: https://git.openjdk.java.net/shenandoah/pull/29