RFR: Mixed evacuation [v7]
Kelvin Nilsen
kdnilsen at openjdk.java.net
Sat Apr 24 14:31:48 UTC 2021
On Thu, 22 Apr 2021 17:53:30 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:
>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Cosmetic improvements requested by review
>>
>> Following these changes, we ran jtreg TIER1 and hotspot_gc_shenandoah tests with no regressions.
>> Also ran a stress Extremem workload.
>
> src/hotspot/share/gc/shenandoah/shenandoahOldGC.cpp line 88:
>
>> 86: entry_coalesce_and_fill();
>> 87:
>> 88: old_heuristics->start_old_evacuations();
>
> Could you encapsulate in entry_old_evacuations() with proper timing/logging? it really helps future debugging the crashes with hs_err file.
Thanks. I've created new function entry_old_evacuations(), which calls entry_coalesce_and_fill() followed by old_heuristics->start_old_evacuations(). There is already timing/logging in entry_coalesce_and_fill(). old_heuristics->start_old_evacuations() just "flips a switch" so that subsequent evacuations will fold in old-gen collection sets so I don't think we need any timing there.
This will show up in next commit.
-------------
PR: https://git.openjdk.java.net/shenandoah/pull/29
More information about the shenandoah-dev
mailing list