RFR: 8272778: Consolidate is_instance and is_instance_inlined in java_lang_String

Claes Redestad redestad at openjdk.java.net
Fri Aug 20 14:19:21 UTC 2021


On Fri, 20 Aug 2021 13:31:02 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Simple change of merging `is_instance` and `is_instance_inlined`.
> 
> Test: build

It seems the split between `is_instance` and `is_instance_inlined` was introduced recently (5314d28f8412e9c993880884a3b626f05b590743) and I think the point to actively opt-out of inlining in performance-insensitive places (also makes the generated code a bit less noisy and easier to debug, by some accounts). 

Since it was done intentionally I'd check we don't lose something by consolidating these into a single inlined version. E.g. measure that the static size of libjvm doesn't grow by much.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5201


More information about the shenandoah-dev mailing list