RFR: 8272778: Consolidate is_instance and is_instance_inlined in java_lang_String

[Albert Mingkun Yang]

On Fri, 20 Aug 2021 14:15:59 GMT, Claes Redestad <redestad at openjdk.org> wrote:

> It seems the split between is_instance and is_instance_inlined was introduced recently (5314d28)

I believe the split was introduced in [8072911: Remove includes of oop.inline.hpp from .hpp files](https://github.com/openjdk/jdk/commit/4913ad5d7dcc8ae4e034aa110a97ea8313b2b3ee) to address potential circular dependencies.

> measure that the static size of libjvm doesn't grow by much.

Before:


ls -l build/*/images/jdk/lib/server/libjvm.so
-rw-r--r-- 1 albert albert 213664560 Aug 20 19:01 build/linux-x64-debug/images/jdk/lib/server/libjvm.so
-rw-r--r-- 1 albert albert  24243456 Aug 20 19:11 build/linux-x64-release/images/jdk/lib/server/libjvm.so


After:


ls -l build/*/images/jdk/lib/server/libjvm.so
-rw-r--r-- 1 albert albert 213727136 Aug 20 19:12 build/linux-x64-debug/images/jdk/lib/server/libjvm.so
-rw-r--r-- 1 albert albert  24247552 Aug 20 19:12 build/linux-x64-release/images/jdk/lib/server/libjvm.so


In summary:

for fastdebug: 213664560 -> 213727136, +62576 bytes, +0.03%
for release: 24243456 -> 24247552, +4096 bytes, +0.02%

-------------

PR: https://git.openjdk.java.net/jdk/pull/5201