RFR: 8260471: Change SystemDictionary::X_klass calls to vmClasses::X_klass [v2]

[Thomas Stuefe]

On Mon, 1 Feb 2021 17:09:42 GMT, Lois Foltan <lfoltan at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   added missing #include systemDictionary.hpp
>
> Looks good!!
> Lois

Hi Ioi,

Sorry, I still get build errors with this (linux x64, fastdebug, nopch):



   link_klass(SystemDictionary::Reference_klass());
                                ^~~~~~~~~~~~~~~

Last Commit:
commit e1a09411c12cdd95bf1f8896100284e0697fafb7 (HEAD -> pull/2301)                                                                                                   │
Author: iklam <ilam3388 at gmail.com>                                                                                                                                    │
Date:   Fri Jan 29 06:22:52 2021 -0800                                                                                                                                │
                                                                                                                                                                      │
    added missing #include systemDictionary.hpp 

I'm also confused why no GA ran for this pr. I gave the patch a cursory read, it reads all okay but of course I cannot see from reading the patch whether we could miss some includes. I'd like to see the GA builds being successful, in this case also for the side platforms and minimal builds/zero.

Thanks, Thomas

-------------

PR: https://git.openjdk.java.net/jdk/pull/2301