RFR: 8260471: Change SystemDictionary::X_klass calls to vmClasses::X_klass [v2]

[Ioi Lam]

On Mon, 1 Feb 2021 18:10:02 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Looks good!!
>> Lois
>
> Hi Ioi,
> 
> Sorry, I still get build errors with this (linux x64, fastdebug, nopch):
> 
> 
> 
>    link_klass(SystemDictionary::Reference_klass());
>                                 ^~~~~~~~~~~~~~~
> 
> Last Commit:
> commit e1a09411c12cdd95bf1f8896100284e0697fafb7 (HEAD -> pull/2301)                                                                                                   │
> Author: iklam <ilam3388 at gmail.com>                                                                                                                                    │
> Date:   Fri Jan 29 06:22:52 2021 -0800                                                                                                                                │
>                                                                                                                                                                       │
>     added missing #include systemDictionary.hpp 
> 
> I'm also confused why no GA ran for this pr. I gave the patch a cursory read, it reads all okay but of course I cannot see from reading the patch whether we could miss some includes. I'd like to see the GA builds being successful, in this case also for the side platforms and minimal builds/zero.
> 
> Thanks, Thomas

> Hi Ioi,
> 
> Sorry, I still get build errors with this (linux x64, fastdebug, nopch):
> 
> ```
> /shared/projects/openjdk/jdk-jdk/source/src/hotspot/share/aot/aotCodeHeap.cpp: In member function 'void AOTCodeHeap::link_known_klasses()':
> /shared/projects/openjdk/jdk-jdk/source/src/hotspot/share/aot/aotCodeHeap.cpp:397:32: error: 'Reference_klass' is not a member of 'SystemDictionary'
>    link_klass(SystemDictionary::Reference_klass());
>                                 ^~~~~~~~~~~~~~~
> ```
> 
> Last Commit:
> 
> ```
> commit e1a09411c12cdd95bf1f8896100284e0697fafb7 (HEAD -> pull/2301)                                                                                                   │
> Author: iklam <ilam3388 at gmail.com>                                                                                                                                    │
> Date:   Fri Jan 29 06:22:52 2021 -0800                                                                                                                                │
>                                                                                                                                                                       │
>     added missing #include systemDictionary.hpp 
> ```
> 
> I'm also confused why no GA ran for this pr. I gave the patch a cursory read, it reads all okay but of course I cannot see from reading the patch whether we could miss some includes. I'd like to see the GA builds being successful, in this case also for the side platforms and minimal builds/zero.
> 
> Thanks, Thomas

I disabled the GitHub Actions for my repo because they were creating too much noise. Instead, I've been testing my builds with Mach5, which has a much larger variety of builds. Unfortunately AOT is disabled by default in Mach5 (due to JDK-8255616: Removal of experimental features AOT and Graal JIT).

Now I've added AOT to my local builds to make sure I don't break it unintentionally. I am also re-enabling GitHub actions on my repo.

I verified that AOT builds again with [8df077d](https://github.com/openjdk/jdk/pull/2301/commits/8df077d47201dbb88171c8137acb57d26f0dd007)

-------------

PR: https://git.openjdk.java.net/jdk/pull/2301