RFR: 8261868: Reduce inclusion of metaspace.hpp [v2]

Ioi Lam iklam at openjdk.java.net
Thu Feb 25 04:36:40 UTC 2021


On Wed, 17 Feb 2021 07:54:28 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed ppc/s390 builds
>
> Hi Ioi,
> 
> this is very appreciated.
> 
> metaspace.hpp is still a bit of a mess. Its the last holdover for the old metaspace implementation and I always wanted to clean it out a bit. Splitting this header into three is a right step.
> 
> A lot of that stuff may still vanish and/or be reformed if I have the time (eg metaspaceChunkFreeListSummary).
> 
> Assuming this builds and tests fine on all our platform, including the weirder ones, I am fine with this patch. It looks good.
> 
> Thanks, Thomas

Thanks @tstuefe and @calvinccheung for the review. I re-tested with the latest repo.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2599


More information about the shenandoah-dev mailing list