RFR: 8261868: Reduce inclusion of metaspace.hpp [v2]

Ioi Lam iklam at openjdk.java.net
Thu Feb 25 06:12:40 UTC 2021


On Thu, 25 Feb 2021 04:30:42 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Hi Ioi,
>> 
>> this is very appreciated.
>> 
>> metaspace.hpp is still a bit of a mess. Its the last holdover for the old metaspace implementation and I always wanted to clean it out a bit. Splitting this header into three is a right step.
>> 
>> A lot of that stuff may still vanish and/or be reformed if I have the time (eg metaspaceChunkFreeListSummary).
>> 
>> Assuming this builds and tests fine on all our platform, including the weirder ones, I am fine with this patch. It looks good.
>> 
>> Thanks, Thomas
>
> Thanks @tstuefe and @calvinccheung for the review. I re-tested with the latest repo.

Note: the commit into the openjdk/jdk repo was successful. https://github.com/openjdk/jdk/commit/0f8be6e433b5d30e028558a4bea0659838d6b700

The previous message by the openjdk bot seems to be an error by the bot.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2599


More information about the shenandoah-dev mailing list