RFR: 8244162: Additional opportunities to use NONCOPYABLE
David Holmes
dholmes at openjdk.java.net
Mon Jul 5 01:54:53 UTC 2021
On Thu, 1 Jul 2021 13:06:55 GMT, Harold Seigel <hseigel at openjdk.org> wrote:
> Please review this small change to use NONCOPYABLE macro where applicable. The change was tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-5 on Linux x64.
>
> Thanks, Harold
Hi Harold,
That all seems quite reasonable. One query below about private constructors.
Thanks,
David
src/hotspot/share/classfile/stackMapTableFormat.hpp line 47:
> 45:
> 46: protected:
> 47: // No constructors - should be 'private', but GCC issues a warning if it is
Have we checked this is still the case? Might be a very old gcc issue.
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4652
More information about the shenandoah-dev
mailing list