RFR: 8244162: Additional opportunities to use NONCOPYABLE

Kim Barrett kbarrett at openjdk.java.net
Tue Jul 6 07:19:51 UTC 2021


On Mon, 5 Jul 2021 01:49:41 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Please review this small change to use NONCOPYABLE macro where applicable.  The change was tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-5 on Linux x64.
>> 
>> Thanks, Harold
>
> src/hotspot/share/classfile/stackMapTableFormat.hpp line 47:
> 
>> 45: 
>> 46:  protected:
>> 47:   // No constructors  - should be 'private', but GCC issues a warning if it is
> 
> Have we checked this is still the case? Might be a very old gcc issue.

I did a little bit of experimenting and couldn't get gcc to warn, though other compilers might do so.  I think such a warning is not unreasonable.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4652


More information about the shenandoah-dev mailing list