RFR: 8244162: Additional opportunities to use NONCOPYABLE

Kim Barrett kbarrett at openjdk.java.net
Tue Jul 6 07:19:51 UTC 2021


On Thu, 1 Jul 2021 13:06:55 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

> Please review this small change to use NONCOPYABLE macro where applicable.  The change was tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-5 on Linux x64.
> 
> Thanks, Harold

Changes requested by kbarrett (Reviewer).

src/hotspot/share/gc/shenandoah/shenandoahReferenceProcessor.hpp line 85:

> 83:   Counters _discovered_count;
> 84:   Counters _enqueued_count;
> 85:   NONCOPYABLE(ShenandoahRefProcThreadLocal);

I think this change should not be made.  We Oracle folks don't make casual changes to Shenandoah, since we don't support or test it.  The Shenandoah team is free to write it out rather than using the macro if they prefer.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4652


More information about the shenandoah-dev mailing list