RFR: 8244162: Additional opportunities to use NONCOPYABLE

[Aleksey Shipilev]

On Tue, 6 Jul 2021 07:03:33 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Please review this small change to use NONCOPYABLE macro where applicable.  The change was tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-5 on Linux x64.
>> 
>> Thanks, Harold
>
> src/hotspot/share/gc/shenandoah/shenandoahReferenceProcessor.hpp line 85:
> 
>> 83:   Counters _discovered_count;
>> 84:   Counters _enqueued_count;
>> 85:   NONCOPYABLE(ShenandoahRefProcThreadLocal);
> 
> I think this change should not be made.  We Oracle folks don't make casual changes to Shenandoah, since we don't support or test it.  The Shenandoah team is free to write it out rather than using the macro if they prefer.

OTOH, it is fine to suggest minor/cosmetic changes to the entirety of the OpenJDK code, and ask others to review/test the bits that are not built/tested by the submitter. 

This change is fine (AFAICS, it is semantically the same as the old code), and it passes `hotspot_gc_shenandoah`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4652