RFR: JDK-8297796 GenShen: instrument the remembered set scan [v12]
Y. Srinivas Ramakrishna
ysr at openjdk.org
Mon Dec 19 23:50:18 UTC 2022
On Mon, 19 Dec 2022 23:43:38 GMT, William Kemper <wkemper at openjdk.org> wrote:
>> Y. Srinivas Ramakrishna has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 65 commits:
>>
>> - Merge branch 'master' into JVM-1264-dependent
>> - Add a previously missed ticket#. Doing it here rather than in parent to
>> avoid an otherwise unnecessary re-review touchpoint.
>> - Merge branch 'stats_merge' into JVM-1264-dependent
>> - Merge branch 'master' into stats_merge
>> - jcheck space fix
>> - Fix compiler error on windows.
>> - Fix some tier1 tests.
>> - Remove an unnecessary include, fix some type incorrectness.
>> - Merge branch 'JVM-1264' into JVM-1264-dependent
>> - Merge branch 'master' into JVM-1264
>> - ... and 55 more: https://git.openjdk.org/shenandoah/compare/bbd4ef34...9c5c741f
>
> src/hotspot/share/gc/shenandoah/shenandoahCardStats.cpp line 57:
>
>> 55: if (record) {
>> 56: // Update global stats for distribution of dirty/clean card %ge
>> 57: _local_card_stats[DIRTY_CARDS].add((double)_dirty_card_cnt*100/(double)_cards_in_cluster);
>
> typo? `%` -> `a`
I mean percentage where I said `%ge`. I'll clarify the comments a bit more. Please continue the review and I'll improve some of the documentation comments for clarity.
-------------
PR: https://git.openjdk.org/shenandoah/pull/176
More information about the shenandoah-dev
mailing list