RFR: JDK-8297796 GenShen: instrument the remembered set scan [v12]

William Kemper wkemper at openjdk.org
Mon Dec 19 23:59:13 UTC 2022


On Mon, 19 Dec 2022 23:47:22 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahCardStats.cpp line 57:
>> 
>>> 55:     if (record) {
>>> 56:       // Update global stats for distribution of dirty/clean card %ge
>>> 57:       _local_card_stats[DIRTY_CARDS].add((double)_dirty_card_cnt*100/(double)_cards_in_cluster);
>> 
>> typo? `%` -> `a`
>
> I mean percentage where I said `%ge`. I'll clarify the comments a bit more. Please continue the review and I'll improve some of the documentation comments for clarity.

Got it - I had `age` on my brain.

-------------

PR: https://git.openjdk.org/shenandoah/pull/176


More information about the shenandoah-dev mailing list