RFR: Do not apply evacuation budgets in non-generational mode [v2]

William Kemper wkemper at openjdk.org
Fri Nov 18 00:34:18 UTC 2022


> CSet selection for non-generational mode was using a value configured on the young generation. In non-generational modes we do not maintain all the attributes of the young generation (instead we maintain the _global_ generation). This caused many cycles in which the maximum CSet was zero (or close to it). This, in turn, caused the collector to run much more frequently (approximately 3x on specjbb) which caused severe performance regression in critical jops.
> 
> I'm not sure why the diff algorithm is struggling so much with these changes. I pulled up the `mode()->is_generational()` out of `compute_evacuation_budgets` and `adjust_evacuation_budgets` into the caller and replaced the check with an assert (re-indenting the code in the method).

William Kemper has updated the pull request incrementally with one additional commit since the last revision:

  Try to improve diff

-------------

Changes:
  - all: https://git.openjdk.org/shenandoah/pull/171/files
  - new: https://git.openjdk.org/shenandoah/pull/171/files/725448fa..b586761f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=shenandoah&pr=171&range=01
 - incr: https://webrevs.openjdk.org/?repo=shenandoah&pr=171&range=00-01

  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/shenandoah/pull/171.diff
  Fetch: git fetch https://git.openjdk.org/shenandoah pull/171/head:pull/171

PR: https://git.openjdk.org/shenandoah/pull/171


More information about the shenandoah-dev mailing list