RFR: Do not apply evacuation budgets in non-generational mode [v2]

[William Kemper]

On Fri, 18 Nov 2022 00:30:00 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> CSet selection for non-generational mode was using a value configured on the young generation. In non-generational modes we do not maintain all the attributes of the young generation (instead we maintain the _global_ generation). This caused many cycles in which the maximum CSet was zero (or close to it). This, in turn, caused the collector to run much more frequently (approximately 3x on specjbb) which caused severe performance regression in critical jops.
>> 
>> I'm not sure why the diff algorithm is struggling so much with these changes. I pulled up the `mode()->is_generational()` out of `compute_evacuation_budgets` and `adjust_evacuation_budgets` into the caller and replaced the check with an assert (re-indenting the code in the method).
>
> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Try to improve diff

src/hotspot/share/gc/shenandoah/shenandoahGeneration.cpp line 795:

> 793:     }
> 794: 
> 795:     heap->assert_pinned_region_status();

This is called again immediately inside collection set selection so I removed this invocation.

-------------

PR: https://git.openjdk.org/shenandoah/pull/171