RFR: 8294438: Fix misleading-indentation warnings in hotspot [v3]

Aleksey Shipilev shade at openjdk.org
Thu Oct 20 07:16:55 UTC 2022


On Wed, 19 Oct 2022 19:11:42 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> There are number of places where misleading-indentation is reported by GCC. Currently, the warning is disabled for the entirety of Hotspot, which is not good.
>> 
>> C1 does an unusual style here. Changing it globally would touch a lot of lines. Instead of doing that, I fit the existing style while also resolving the warnings. Note this actually solves a bug in `lir_alloc_array`, where `do_temp` are called without a check.
>> 
>> Build-tested this with product of:
>>   - GCC 10
>>   - {i686, x86_64, aarch64, powerpc64le, s390x, armhf, riscv64}
>>   - {server, zero}
>>   - {release, fastdebug}
>> 
>> Linux x86_64 fastdebug `tier1` is fine.
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
> 
>  - Merge branch 'master' into JDK-8294438-misleading-indentation
>  - Merge branch 'master' into JDK-8294438-misleading-indentation
>  - Merge branch 'master' into JDK-8294438-misleading-indentation
>  - Also javaClasses.cpp
>  - Fix

Thanks!

-------------

PR: https://git.openjdk.org/jdk/pull/10444


More information about the shenandoah-dev mailing list